Skip to content

feat: forward screen custom attributes #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat: forward screen custom attributes #29

merged 2 commits into from
Feb 20, 2025

Conversation

mmustafa-tse
Copy link
Contributor

Summary

  • Since we're using logEvent for screen views, we can now send the screen view event's custom attributes as part of the Params

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • Testing was done for both E2E and unit testing

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmustafa-tse mmustafa-tse mentioned this pull request Jan 31, 2025
Merged
@BrandonStalnaker
Copy link
Contributor

@mmustafa-tse Could you resolve the conflicts here?

@BrandonStalnaker BrandonStalnaker merged commit 3792343 into development Feb 20, 2025
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/updateLogScreen branch February 20, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmustafa-tse @BrandonStalnaker